[coreboot-gerrit] Change in coreboot[master]: soc/amd: move non-CAR linker scripts to common directory

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47828 )

Change subject: soc/amd: move non-CAR linker scripts to common directory
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
PS2, Line 32:  *                     |                                |X86_RESET_VECTOR = ROMSTAGE_ADDR + ROMSTAGE_SIZE - 0x10
> the reset vector isn't in romstage, but in bootblock, so this is wrong. […]

Yes, this comment needs update. It was from back when romstage was the first stage to start on x86 (changes were only in chromium tree, but while porting to upstream, the comment wasn't fixed).

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
PS2, Line 86: 	_ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned");
> not 100% certain on this and couldn't find a definite answer at the places i thought it was most lik […]

Seems to be coming from: https://review.coreboot.org/c/coreboot/+/42885

+Raul.