Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36871 )
Change subject: mb/lenovo/{t410,x201}: Make T410 a variant board of X201 ......................................................................
Patch Set 12:
(2 comments)
Most of the changes have nothing to do with using variants. Please split those off before this can be reviewed.
https://review.coreboot.org/c/coreboot/+/36871/12/src/mainboard/lenovo/x201/... File src/mainboard/lenovo/x201/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/36871/12/src/mainboard/lenovo/x201/... PS12, Line 32: /* ME may not be up yet. */ : Store (0, _TZ.MEB1) : Store (0, _TZ.MEB2) You likely break at least S3 resume with this.
https://review.coreboot.org/c/coreboot/+/36871/12/src/mainboard/lenovo/x201/... File src/mainboard/lenovo/x201/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/36871/12/src/mainboard/lenovo/x201/... PS12, Line 20: : void acpi_create_gnvs(global_nvs_t *gnvs) : { : gnvs->tcrt = CRITICAL_TEMPERATURE; : gnvs->tpsv = PASSIVE_TEMPERATURE; : : /* the lid is open by default. */ : gnvs->lids = 1; Please do all these changes that have nothing to do with variants in different CL.