Most of the changes have nothing to do with using variants. Please split those off before this can be reviewed.

View Change

2 comments:

• File src/mainboard/lenovo/x201/acpi/platform.asl:

  • Patch Set #12, Line 32:

    /* ME may not be up yet.  */
    	Store (0, \_TZ.MEB1)
    	Store (0, \_TZ.MEB2)
    

    You likely break at least S3 resume with this.

• File src/mainboard/lenovo/x201/acpi_tables.c:

  • Patch Set #12, Line 20:

    
    void acpi_create_gnvs(global_nvs_t *gnvs)
    {
    	gnvs->tcrt = CRITICAL_TEMPERATURE;
    	gnvs->tpsv = PASSIVE_TEMPERATURE;
    
    	/* the lid is open by default. */
    	gnvs->lids = 1;
    

    Please do all these changes that have nothing to do with variants in different CL.

To view, visit change 36871. To unsubscribe, or for help writing mail filters, visit settings.