Attention is currently required from: Felix Singer, Iru Cai, Riku Viitanen.
Angel Pons has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/39398?usp=email )
Change subject: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/hp/snb_ivb_laptops/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/39398/comment/bca18716_dbb7685a?usp... : PS6, Line 13: ifeq ($(CONFIG_BOARD_HP_8560W),y) : cbfs-files-y += mxm-30-sis : mxm-30-sis-file := variants/$(VARIANT_DIR)/mxm.cfg : mxm-30-sis-type := raw : endif ```suggestion subdirs-y += $(wildcard variants/$(VARIANT_DIR)/Makefile.mk) ```
Then put this in your variant's `Makefile.mk`:
``` ## <license header>
cbfs-files-y += mxm-30-sis mxm-30-sis-file := mxm.bin mxm-30-sis-type := raw ```
If you expect other boards to use this in the future, perhaps it should be moved out of mainboards and controlled via a Kconfig option.