[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Iru Cai, Riku Viitanen.

Angel Pons has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/39398?usp=email )

Change subject: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant
......................................................................


Patch Set 6:

(1 comment)

File src/mainboard/hp/snb_ivb_laptops/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/39398/comment/bca18716_dbb7685a?usp... :
PS6, Line 13: ifeq ($(CONFIG_BOARD_HP_8560W),y)
            : cbfs-files-y += mxm-30-sis
            : mxm-30-sis-file := variants/$(VARIANT_DIR)/mxm.cfg
            : mxm-30-sis-type := raw
            : endif
```suggestion
subdirs-y += $(wildcard variants/$(VARIANT_DIR)/Makefile.mk)
```

Then put this in your variant's `Makefile.mk`:

```
## <license header>

cbfs-files-y += mxm-30-sis
mxm-30-sis-file := mxm.bin
mxm-30-sis-type := raw
```

If you expect other boards to use this in the future, perhaps it should be moved out of mainboards and controlled via a Kconfig option.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/39398?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15181792b1efa45a2a94d78e43c6257da1acf950
Gerrit-Change-Number: 39398
Gerrit-PatchSet: 6
Gerrit-Owner: Iru Cai <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Iru Cai <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Riku Viitanen <[e-mail]>
Gerrit-Attention: Riku Viitanen <[e-mail]>
Gerrit-Attention: Felix Singer <[e-mail]>
Gerrit-Attention: Iru Cai <[e-mail]>
Gerrit-Comment-Date: Tue, 11 Jun 2024 10:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No