Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 )
Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH c.pomaska@hosting.de
Honestly I have no idea. […]
Usually we argue that copyright only applies to code and not to "config" files that have a predefined fixed pattern. Due to that most devicetree.cb, Makefile and Kconfig doesn't even include a copyright header.
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 55: register "gen1_dec" = "0x00000295" # Super I/O HWM that seems needed for the nct6776 0xb LDN.
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000" 0x2e8 isn't routed to LPC but enabled on aspeed