David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37445 )
Change subject: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
Minor nit, otherwise looks good to me.
https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake/...
PS8, Line 133: } else
nit: use braces for the else clauses, since the if clauses are multiple lines
(See https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces, in the example before the Spaces section)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I58cbe95055dea053b115e99f354f40d5902c6a35
Gerrit-Change-Number: 37445
Gerrit-PatchSet: 8
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Dec 2019 00:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment