Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee...
PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
I'd prefer if this would be corrected here instead of on CB:44079
This is generated by the tool https://chromium.googlesource.com/chromiumos/platform/dev-util/+/refs/heads/... and template https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/uti... .
I vote to split the gpio setting to the other patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08923cde932b7304bcb01cd747530c87949e4692
Gerrit-Change-Number: 44074
Gerrit-PatchSet: 8
Gerrit-Owner: Julia Tsai
julia.tsai@lcfc.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Aug 2020 04:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment