Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33235 )
Change subject: cpu/x86/smm: Add STM Support ......................................................................
Patch Set 13:
(1 comment)
Patch Set 6:
(14 comments)
Patch Set 6:
Eugene, if you're willing, I'd like to help you get this into Coreboot Normal Form. It's not that there's anything terribly wrong with this code, it just needs to be reshaped a tad. Can I help?
Thanks for the offer. The next patch set will non-CamelCase and it should be in line with the coreboot coding standard. So, wait until I put out the next patchset as it is 99% done.
https://review.coreboot.org/c/coreboot/+/33235/6/src/cpu/x86/smm/smm_module_... File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/33235/6/src/cpu/x86/smm/smm_module_... PS6, Line 198: printk(BIOS_DEBUG, "MSEG Initialized (%d) 0x%08x 0x%08x\n",
The MSEG (MSR) and SMM Descriptor has to be initialized on a per-thread (logical processor) basis. […]
Done