Patch Set 6:

(14 comments)

Patch Set 6:

Eugene, if you're willing, I'd like to help you get this into Coreboot Normal Form. It's not that there's anything terribly wrong with this code, it just needs to be reshaped a tad. Can I help?

Thanks for the offer. The next patch set will non-CamelCase and it should be in line with the coreboot coding standard. So, wait until I put out the next patchset as it is 99% done.

View Change

1 comment:

To view, visit change 33235. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I935cd5a8bc0bf293240324c2e3a04a655d44c69f
Gerrit-Change-Number: 33235
Gerrit-PatchSet: 13
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-CC: ron minnich <rminnich@gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 18:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1002358
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment