Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: soc/intel: Fix for missing mem_rank info in SMBIOS ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/#/c/31235/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31235/5//COMMIT_MSG@8 PS5, Line 8: Can you please add 2 or 3 line description regarding what the problem currently is without this change and how this change is addressing that.
https://review.coreboot.org/#/c/31235/5//COMMIT_MSG@9 PS5, Line 9: Found-by: Google I am not sure if this is common to add a "Found-by:" line. I haven't seen it in the past or done it myself. Again it is for my own knowledge.
https://review.coreboot.org/#/c/31235/5//COMMIT_MSG@10 PS5, Line 10: BUG=Wrong memory rank info in SMBIOS Please update this line to "BUG=b:122329046" as Furquan mentioned in one of his previous comments
https://review.coreboot.org/#/c/31235/5//COMMIT_MSG@11 PS5, Line 11: TEST=Boot to OS Seems this change was done to improve the performance. If so did you run any test related to performance profiling and can you please add that information here.
https://review.coreboot.org/#/c/31235/5/3rdparty/blobs File 3rdparty/blobs:
https://review.coreboot.org/#/c/31235/5/3rdparty/blobs@a1 PS5, Line 1: Is this Delete intentional? Is it related to the change?