View Change
5 comments:
Commit Message:
Patch Set #5, Line 8:
Can you please add 2 or 3 line description regarding what the problem currently is without this change and how this change is addressing that.
Patch Set #5, Line 9: Found-by: Google
I am not sure if this is common to add a "Found-by:" line. I haven't seen it in the past or done it myself. Again it is for my own knowledge.
Patch Set #5, Line 10: BUG=Wrong memory rank info in SMBIOS
Please update this line to "BUG=b:122329046" as Furquan mentioned in one of his previous comments
Patch Set #5, Line 11: TEST=Boot to OS
Seems this change was done to improve the performance. If so did you run any test related to performance profiling and can you please add that information here.
File 3rdparty/blobs:
To view, visit change 31235. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212215040e4786c258a9c604cc5c2bb62867c842
Gerrit-Change-Number: 31235
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso@intel.corp-partner.google.com>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 06 Feb 2019 03:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment