Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )
Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
I should re-test
File src/soc/intel/broadwell/pch/sata.c:
https://review.coreboot.org/c/coreboot/+/47029/comment/c435c9fa_bcb6158d
PS3, Line 66: reg32 |= 1 << 29; /* BWG step 11 */
Already set near the end of this function?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00
Gerrit-Change-Number: 47029
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 08 Feb 2021 21:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment