Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )
Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/soc/intel/broadwell/pch/sata.c:
https://review.coreboot.org/c/coreboot/+/47029/comment/d74736ca_ef3ce32b
PS3, Line 66: reg32 |= 1 << 29; /* BWG step 11 */
Already set near the end of this function?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00
Gerrit-Change-Number: 47029
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 08 Feb 2021 21:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment