Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44014 )
Change subject: src/soc/intel/common/block: Mark only TSEG range as IO_CACHEABLE
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44014/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44014/3//COMMIT_MSG@10
PS3, Line 10: that one can perform SMRAM relocation faster.
But this was already happening.
https://review.coreboot.org/c/coreboot/+/44014/3//COMMIT_MSG@15
PS3, Line 15: range as cacheable (+ reserved) and other ranges as reserve alone.
What's the motivation? If the order of operations is maintained (us doing mpinit w/ smm relocation early) one can just omit tseg from being a reserved ram resource because we've done all that work already. i.e. keep one memory map for init and the one we expose to OS as different.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64c14b14caf0a53219fdc02ec6bbd375955a0c8e
Gerrit-Change-Number: 44014
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 21:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment