Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )
Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@7
PS1, Line 7: mb/google/octopus/variants/dood: add new SKU ID
Add two new SKU IDs
fixed
https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@11
PS1, Line 11:
One space.
fixed
https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@17
PS1, Line 17: moden status
What is that?
fixed
https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/dood/gpio.c:
https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu...
PS1, Line 25: */
Space before */.
fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Gerrit-Change-Number: 38730
Gerrit-PatchSet: 2
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Feb 2020 00:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment