Attention is currently required from: David Hendricks, Elyes Haouas, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel.
Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support
......................................................................
Patch Set 57:
(1 comment)
File src/mainboard/apple/macbookpro10_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/b3ed7e52_640ebde5?usp... :
PS57, Line 8: #include <cbfs.h>
not sure if this is needed or not
`spd_file = cbfs_map("spd.bin", &spd_file_len);`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df
Gerrit-Change-Number: 32673
Gerrit-PatchSet: 57
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 03 Aug 2024 10:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr