Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: add TX tracking for DRAM DVFS ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: DVFS DVFS.
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: use Use
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: tracking track
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... PS8, Line 22: default y Shouldn't change this.
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2345: if (shu_src >= DRAM_DFS_SHUFFLE_MAX || shu_dst>= DRAM_DFS_SHUFFLE_MAX) {
spaces required around that '>=' (ctx:VxW)
Please fix this.
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2351: div_round_close((get_shu_frequency(shu_dst) >> 1)* 32,
need consistent spacing around '*' (ctx:VxW)
Please fix this.