Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40243 )
Change subject: fmap: Avoid unaligned access
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
What's the status of this CL? I still think that this is the wrong way to go about this problem. From my understanding of b/153593670, we were still hoping for AMD to change the cache settings for memory-mapped ROM, and if that's impossible we'd prefer to handle this with a platform-specific boot_device rdev. We shouldn't be hacking up common code for it.
AMD has been very resistant to enabling caching of the spi rom. I need to get this running at coreboot.org so we can switch over. I'll come up with a different solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ac83766616cb2107b75eba6995cd09b4fc90968
Gerrit-Change-Number: 40243
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Comment-Date: Sun, 07 Jun 2020 21:37:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment