Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35271 )
Change subject: soc/amd/common/lpc: Add SuperIO decode function ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/in... PS2, Line 78: 1 true
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/in... PS2, Line 78: #define LPC_SELECT_SIO_4E4F 1 Add a comment explaining why these 2 defines are Boolean
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/in... PS2, Line 79: 0 false
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/lp... PS2, Line 168: addr Maybe for clarity, is_it_uart1
https://review.coreboot.org/c/coreboot/+/35271/2/src/soc/amd/common/block/lp... PS2, Line 174: LPC_SELECT_SIO_2E2F Making the input a bool, the check against a value is no longer needed and makes no sense. enable = addr ? DECODE_SIO_ENABLE : DECODE_ALTERNATE_SIO_ENABLE