View Change

5 comments:

• File src/soc/amd/common/block/include/amdblocks/lpc.h:

  • Patch Set #2, Line 78: 1

    true

  • Patch Set #2, Line 78: #define LPC_SELECT_SIO_4E4F 1

    Add a comment explaining why these 2 defines are Boolean

  • Patch Set #2, Line 79: 0

    false

• File src/soc/amd/common/block/lpc/lpc_util.c:

  • Patch Set #2, Line 168: addr

    Maybe for clarity, is_it_uart1

  • Patch Set #2, Line 174: LPC_SELECT_SIO_2E2F

    Making the input a bool, the check against a value is no longer needed and makes no sense.
    enable = addr ? DECODE_SIO_ENABLE : DECODE_ALTERNATE_SIO_ENABLE

To view, visit change 35271. To unsubscribe, or for help writing mail filters, visit settings.