Attention is currently required from: Nico Huber, Martin Roth, Eugene Myers, Paul Menzel, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 195: Verified+1
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/c961b06c_8408f3f8 PS195, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/887e2a69_b9191b3f PS195, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/8c92fbf1_963a0933 PS195, Line 302: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/2ff0de5e_3c745d83 PS195, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/1736021c_17136484 PS195, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/2374e57a_33c24638 PS195, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/8e470313_e8c043e4 PS195, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/648db184_3bc5972e PS195, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/5b5e9d41_09aea3d3 PS195, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/3f23591b_a7e71145 PS195, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/ac756b12_12f312d3 PS195, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/a93353cc_a72fa0eb PS195, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139308): https://review.coreboot.org/c/coreboot/+/35523/comment/8a92ecad_6264dcd7 PS195, Line 160: if (gnvs) { braces {} are not necessary for single statement blocks