Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48519 )
Change subject: mb/purism/librem_cnl: move setting of FSP-M UPDs into variant.c ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/48519/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48519/1//COMMIT_MSG@9 PS1, Line 9: will not nit: use `won't` so that this line doesn't exceed 72 chars
https://review.coreboot.org/c/coreboot/+/48519/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48519/1/src/mainboard/purism/librem... PS1, Line 3: double blank line
https://review.coreboot.org/c/coreboot/+/48519/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/variant.h:
PS1: You'd want to move this file to: mb/purism/librem_cnl/include/variant.h Otherwise, you need to copy it to every variant, and its contents are not variant-specific. See kontron/bsl6 for a good example.