Patch set 1:Code-Review +1
3 comments:
Patch Set #1, Line 9: will not
nit: use `won't` so that this line doesn't exceed 72 chars
File src/mainboard/purism/librem_cnl/Makefile.inc:
double blank line
File src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/variant.h:
You'd want to move this file to: mb/purism/librem_cnl/include/variant.h
Otherwise, you need to copy it to every variant, and its contents are not variant-specific. See kontron/bsl6 for a good example.
To view, visit change 48519. To unsubscribe, or for help writing mail filters, visit settings.