Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )
Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33857/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33857/2/src/mainboard/google/hatch/...
PS2, Line 53: # GPIO community PM configuration
: register "gpio_pm[COMM_0]" = "0"
: register "gpio_pm[COMM_1]" = "0"
: register "gpio_pm[COMM_2]" = "0"
: register "gpio_pm[COMM_3]" = "0"
This should be a separate change of its own. Also, we are trying to evaluate the impact of disabling PM configuration for all communities. Let's not add this in here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05
Gerrit-Change-Number: 33857
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jul 2019 00:09:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment