Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44014 )
Change subject: src/soc/intel/common: Make top_of_ram till TOLUD region mmio_resource
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44014/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44014/3//COMMIT_MSG@15
PS3, Line 15: range as cacheable (+ reserved) and other ranges as reserve alone.
@Aaron, i guess you meant this https://review.coreboot. […]
That is what I meant. If we've already utilized TSEG from early mtrr solution and it was marked cacheable we get the speed up. After that we finalize our MTRR solution for boot. Looks like we do what I noted when !CONFIG(USE_INTEL_FSP_MP_INIT). When CONFIG(USE_INTEL_FSP_MP_INIT) = y then that assumption breaks down looking at post_cpus_init() in src/soc/intel/common/block/cpu/mp_init.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64c14b14caf0a53219fdc02ec6bbd375955a0c8e
Gerrit-Change-Number: 44014
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jul 2020 14:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment