Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44512 )
Change subject: soc/intel/common: Call pci_dev_enable_bus_master() from .final ops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG@15 PS2, Line 15: access
Not sure what you mean here. […]
valid point.
Ideally below register bit should be written by the firmware and should never be changed by the device driver. FW OS Command/Bus Master Write to 0 (reset value) unless boot device. Must write to a 1 before the first DMA operation. Must write to a 0 before unconfiguring device driver.
will wait for Furquan to share his idea, bt i think we should only enable bus master for boot associated device like SATA, USB, PCIE, EMMC, SD etc and all other controller should be ignored by BIOS/FW but OS driver should enable 1 to allow DMA access. I guess Furquan meant to enable this for all PCI device by default