View Change
1 comment:
Commit Message:
Patch Set #2, Line 15: access
Not sure what you mean here. […]
valid point.
Ideally below register bit should be written by the firmware and should never be changed by the device driver.
FW OS
Command/Bus Master Write to 0 (reset value) unless boot device. Must write to a 1 before the first DMA operation. Must write to a 0 before unconfiguring device driver.
will wait for Furquan to share his idea, bt i think we should only enable bus master for boot associated device like SATA, USB, PCIE, EMMC, SD etc and all other controller should be ignored by BIOS/FW but OS driver should enable 1 to allow DMA access. I guess Furquan meant to enable this for all PCI device by default
To view, visit change 44512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife65f6029d2f966e321f616e85f59f4c37c42145
Gerrit-Change-Number: 44512
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Comment-Date: Mon, 17 Aug 2020 09:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-MessageType: comment