Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard ......................................................................
Patch Set 24:
(10 comments)
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: mb/ongy/h61m-s1: Add new mainboard Mention the socket/chipset in the summary, so people can better classify the device at first look.
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: ongy I have never heard of them.
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@9 PS24, Line 9: Port done with the autoport utility Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@10 PS24, Line 10: As there is no documentation added, please mention how to flash the image. Can the BIOS region be flashed with flashrom’s internal programmer when running the vendor firmware?
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@14 PS24, Line 14: 4.15.0-99-generic I thought that is the Linux kernel for 16.04.
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@25 PS24, Line 25: - Tianocore payload (CorebootPayload) What is the error?
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig... PS24, Line 1: Please remove the blank line.
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 5: */ Please format the comment correctly. Is that still generated this way by current autoport?
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 11: /*The _WAK method is called on system wakeup*/ Please add spaces.
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 15: Return(Package(){0,0}) Please add spaces. Current autoport should have fixed this.