10 comments:
Patch Set #24, Line 7: mb/ongy/h61m-s1: Add new mainboard
Mention the socket/chipset in the summary, so people can better classify the device at first look.
I have never heard of them.
Patch Set #24, Line 9: Port done with the autoport utility
Please add a dot/period at the end.
As there is no documentation added, please mention how to flash the image. Can the BIOS region be flashed with flashrom’s internal programmer when running the vendor firmware?
Patch Set #24, Line 14: 4.15.0-99-generic
I thought that is the Linux kernel for 16.04.
Patch Set #24, Line 25: - Tianocore payload (CorebootPayload)
What is the error?
File src/mainboard/ongy/Kconfig:
Please remove the blank line.
File src/mainboard/ongy/h61m-s1/acpi/platform.asl:
Please format the comment correctly. Is that still generated this way by current autoport?
Patch Set #24, Line 11: /*The _WAK method is called on system wakeup*/
Please add spaces.
Patch Set #24, Line 15: Return(Package(){0,0})
Please add spaces. Current autoport should have fixed this.
To view, visit change 40813. To unsubscribe, or for help writing mail filters, visit settings.