Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 36:
(13 comments)
File Documentation/mainboard/apple/macbookpro10_1.md:
https://review.coreboot.org/c/coreboot/+/32673/comment/37414a6d_43948669 PS35, Line 16: 8MB
MiB
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/e85e9045_81115eff PS35, Line 29: 8GB
GiB
Done
File src/mainboard/apple/macbookpro10_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/32673/comment/30424565_5e155959 PS35, Line 19: select DRIVERS_APPLE_HYBRID_GRAPHICS
I'd sort the selected options alphabetically.
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/eb2f6ce6_e70b5a37 PS35, Line 29: config VGA_BIOS_FILE : string : default "pci8086,0166.rom"
Please drop this option. Not everyone will use a file named `pci8086,0166.rom`.
Done
File src/mainboard/apple/macbookpro10_1/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/32673/comment/a9e4269c_587142e8 PS22, Line 2: : cbfs-files-y += spd.bin : spd.bin-file := spd.bin : spd.bin-type := spd
This could use the GENERIC_SPD mechanism. […]
Done
File src/mainboard/apple/macbookpro10_1/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/32673/comment/04f0f424_43533325 PS35, Line 8: spd.bin-file := spd.bin
For memory down SPD data, we usually have a plain-text file and use the `GENERIC_SPD_BIN` Kconfig op […]
Done
File src/mainboard/apple/macbookpro10_1/cmos.default:
https://review.coreboot.org/c/coreboot/+/32673/comment/ddc1a5e7_1380f033 PS25, Line 3:
gfx_uma_size=32M
Done
File src/mainboard/apple/macbookpro10_1/cmos.layout:
PS35:
Please get rid of the commented-out options. I'd suggest grabbing a cmos. […]
Done
File src/mainboard/apple/macbookpro10_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32673/comment/dd0d735c_7f20eca0 PS35, Line 24: 0x8086 0x7270
Replace the IDs in here with `0x106b 0x00f7` and drop all other `subsystemid 0x106b 0x00f7` lines
Done
File src/mainboard/apple/macbookpro10_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/fdd97aaa_780ca2af PS35, Line 12: pci_write_config16(PCH_LPC_DEV, LPC_EN, 0x3f0f); : pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x000c0681); : pci_write_config32(PCH_LPC_DEV, LPC_GEN2_DEC, 0x000c1641); : pci_write_config32(PCH_LPC_DEV, LPC_GEN3_DEC, 0x001c0301); : pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x00fc0701); : pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0070); : }
Shouldn't be needed.
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/125c51d3_ba2025e3 PS35, Line 45: PCI_DEV(0, 0, 0)
HOST_BRIDGE
Done
File src/mainboard/apple/macbookpro10_1/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/32673/comment/acecb15a_3a3fbcf7 PS22, Line 30: Analog
Hmm?
Removed.
File src/mainboard/apple/macbookpro10_1/romstage.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/a362f354_d17d22ca PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
RAMCFG[0.. […]
Done