Attention is currently required from: Lance Zhao, Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath, Subrata Banik, Archana Patni, Michael Niewöhner, Ronak Kanabar.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59790 )
Change subject: mb/google/brya: Fix S0i3 regression
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59790/comment/280e2da5_226a8e43
PS2, Line 8:
Please describe the problem. S0i3 does not work how?
https://review.coreboot.org/c/coreboot/+/59790/comment/a89bfbd7_67d12948
PS2, Line 9: CB
coreboot
https://review.coreboot.org/c/coreboot/+/59790/comment/3efc18e0_81d506c8
PS2, Line 12:
Please add the tag:
Fixes: 0e905801 (soc/intel: transition full control over PM Timer from FSP to coreboot)
https://review.coreboot.org/c/coreboot/+/59790/comment/d93cc4d8_41d449ea
PS2, Line 14: TEST=Boot gimble to OS and verify S0i3 counter incrementing
How can this be verified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8005dacd732c033980ccc479375ff5b06df8dac1
Gerrit-Change-Number: 59790
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Archana Patni
archana.patni@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Archana Patni
archana.patni@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 10:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment