11 May
2020
11 May
'20
1:08 p.m.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41248 )
Change subject: soc/amd/common/block/spi: Add support for common SPI configuration ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41248/4/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/41248/4/src/soc/amd/common/block/sp... PS4, Line 69: fch_spi_config_modes Does all this logic belong in fch_spi_ctrl.c?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4f231bab69e8450005dd6abe7a8e014d5eb7261
Gerrit-Change-Number: 41248
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 May 2020 20:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment