Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 3: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG@11 PS3, Line 11: Please roughly mention, that there is no audio device, and that OHCI is outdated.
Was the table copy-pasted from some other board?
https://review.coreboot.org/c/coreboot/+/42097/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/3/src/mainboard/pcengines/apu... PS3, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00, This should be a separate commit. There are more occurrences.
$ git grep 0x1f src/mainboard/pcengines/apu2/mainboard.c src/mainboard/pcengines/apu2/mainboard.c: [0x10] = 0x09,0x1F,0x1F,0x1F,0x1F,0x1f,0x1F,0x10, src/mainboard/pcengines/apu2/mainboard.c: [0x30] = 0x12,0x1f,0x12,0x1F,0x12,0x1F,0x1F,0x00, src/mainboard/pcengines/apu2/mainboard.c: [0x40] = 0x1f,0x13,0x00,0x00,0x00,0x00,0x00,0x00,