Patch set 3:-Code-Review
2 comments:
Please roughly mention, that there is no audio device, and that OHCI is outdated.
Was the table copy-pasted from some other board?
File src/mainboard/pcengines/apu2/mainboard.c:
Patch Set #3, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00,
This should be a separate commit. There are more occurrences.
$ git grep 0x1f src/mainboard/pcengines/apu2/mainboard.c
src/mainboard/pcengines/apu2/mainboard.c: [0x10] = 0x09,0x1F,0x1F,0x1F,0x1F,0x1f,0x1F,0x10,
src/mainboard/pcengines/apu2/mainboard.c: [0x30] = 0x12,0x1f,0x12,0x1F,0x12,0x1F,0x1F,0x00,
src/mainboard/pcengines/apu2/mainboard.c: [0x40] = 0x1f,0x13,0x00,0x00,0x00,0x00,0x00,0x00,
To view, visit change 42097. To unsubscribe, or for help writing mail filters, visit settings.