Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48654 )
Change subject: mb/ocp/tiogapass/devicetree.cb: Add P2SB device
......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
Patch Set 3:
Can we - even on commits that do fix the master for boards again - keep the 24 hour rule? Or get additional +2's..
I second that. For reference, here's the guidelines: https://doc.coreboot.org/getting_started/gerrit_guidelines.html
Sorry, Thought 2 was enough. I'll leave them next time.
https://review.coreboot.org/c/coreboot/+/48654/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48654/1//COMMIT_MSG@9
PS1, Line 9: tiago
That wasn't changed, but it's too late now
ah darn, I changed the one above and missed this one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia37bd0f14627980345cd07f20e935a10d4760b69
Gerrit-Change-Number: 48654
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 16:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment