Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49100 )
Change subject: mb/intel/adlrvp: Fix DEKEL FW download failed for PEG 060 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49100/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49100/1/src/mainboard/intel/adlrvp/... PS1, Line 71: CPU
this comment is wrong. i will fix it in another CL, its not CPU RP, its PCH RP […]
If this is PCH RP1, what about its CLKSRC# and CLKREQ# configuration? If RP1 is using CLKSRC0 and CLKREQ0 shouldn't this configuration be:
register "PcieRpEnable[0]" = "1" register "PcieClkSrcUsage[0]" = "0" register "PcieClkSrcClkReq[0]" = "0"
Basically, what you have on line #73 is also incorrect.