[coreboot-gerrit] [L] Change in coreboot[main]: mb/apple: Add MacBook Pro 10,1 (A1398) support

[Felix Singer (Code Review)]

Attention is currently required from: Angel Pons, David Hendricks, Elyes Haouas, Evgeny Zinoviev, Martin L Roth, Paul Menzel.

Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email )

Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support
......................................................................

Patch Set 58:

(5 comments)

File Documentation/mainboard/apple/mbp101_board.jpg:

PS57:
> You should not be executable

Done

File src/mainboard/apple/macbookpro10_1/cmos.default:

PS57:
> Add license header as per commit e623845df64b28d2c809e40c0703d18d6bc246c4

Done

File src/mainboard/apple/macbookpro10_1/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/32673/comment/f6836b7a_fc459021?usp... :
PS57, Line 6: device ref peg10 on end
            : 		device ref peg12 on end
            : 		device ref peg11 on end
> nit: order […]

Done

https://review.coreboot.org/c/coreboot/+/32673/comment/da491439_6edde5ee?usp... :
PS57, Line 29: 			register "spi_lvscc" = "0x0"
> Isn't this the default?

Done

https://review.coreboot.org/c/coreboot/+/32673/comment/a7761992_40200043?usp... :
PS57, Line 35: 			device ref mei1 on end
> Isn't MEI1 enabled by default?

Done