Attention is currently required from: Bao Zheng.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry
......................................................................
Patch Set 27:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/c96cb46d_ce193573
PS27, Line 11: to config file. Then the required size of space will
: be allocated related to the firmware type.
Maybe add a comment as to why this is needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae
Gerrit-Change-Number: 49015
Gerrit-PatchSet: 27
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 21:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment