Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44293 )
Change subject: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic ......................................................................
Patch Set 4:
(3 comments)
File src/drivers/amd/agesa/s3_mtrr.c:
https://review.coreboot.org/c/coreboot/+/44293/comment/205de028_aa257c05 PS4, Line 67: disable_cache(); Disappears without argumentation.
https://review.coreboot.org/c/coreboot/+/44293/comment/2966db87_25e69f34 PS4, Line 47: mtrr_save->mtrr_phys_mask[i] = rdmsr(MTRR_PHYS_BASE(i)); MTRR_PHYS_MASK(i)
Maybe you want to read BASE() first, althought it does not matter
https://review.coreboot.org/c/coreboot/+/44293/comment/c4167b25_7e6f209b PS4, Line 82: wrmsr(MTRR_PHYS_BASE(i), mtrr_save->mtrr_phys_mask[i]); MTRR_PHYS_MASK(i)
Since valid bit is in MASK register, BASE should be programmed first.