David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass ......................................................................
Patch Set 31:
(1 comment)
Patch Set 31: Code-Review-1
(1 comment)
There seems to be something wrong with Kconfig... here's an error I see when I try to `make menuconfig`: $ make menuconfig warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS) selects FSP_USE_REPO which has unmet direct dependencies (PLATFORM_USES_FSP1_1 && SOC_INTEL_BRASWELL && !USE_GOOGLE_FSP || PLATFORM_USES_FSP2_0 && ADD_FSP_BINARIES && (SOC_INTEL_APOLLOLAKE || SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE || SOC_INTEL_ICELAKE || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_XEON_SP))
*** ERROR: 1 warnings encountered, and warnings are errors.
Your configuration changes were NOT saved.
Turns out we just need to select ADD_FSP_BINARIES in the mainboard's Kconfig.
https://review.coreboot.org/c/coreboot/+/38549/31/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38549/31/src/mainboard/ocp/tiogapas... PS31, Line 21: def_bool y select ADD_FSP_BINARIES