Patch Set 31: Code-Review-1

(1 comment)

There seems to be something wrong with Kconfig... here's an error I see when I try to `make menuconfig`:
$ make menuconfig
warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS) selects FSP_USE_REPO which has unmet direct dependencies (PLATFORM_USES_FSP1_1 && SOC_INTEL_BRASWELL && !USE_GOOGLE_FSP || PLATFORM_USES_FSP2_0 && ADD_FSP_BINARIES && (SOC_INTEL_APOLLOLAKE || SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE || SOC_INTEL_ICELAKE || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_XEON_SP))

*** ERROR: 1 warnings encountered, and warnings are errors.

Your configuration changes were NOT saved.

Turns out we just need to select ADD_FSP_BINARIES in the mainboard's Kconfig.

View Change

1 comment:

• File src/mainboard/ocp/tiogapass/Kconfig:

  • Patch Set #31, Line 21: def_bool y

    select ADD_FSP_BINARIES

To view, visit change 38549. To unsubscribe, or for help writing mail filters, visit settings.