Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@8
PS3, Line 8: for vilboz
Please put that on the line above.
https://review.coreboot.org/c/coreboot/+/43161/3//COMMIT_MSG@10
PS3, Line 10: At this moment, Vilboz board version is 1 and it
: follows v3+ schematics, however WiFi power enable
: is active high.
… according to the schematics?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43161
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997
Gerrit-Change-Number: 43161
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 06:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment