Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override if present ......................................................................
Patch Set 40:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c@10 PS36, Line 10: struct
ugh, i see const is propagating... could you fix this API […]
Yes, it was propagating, but the right thing to do.
I'm hesitant to change the blk->spd_array[] from it's current type to a constant (it's an array, so it's likely initialized at some point).
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c@193 PS36, Line 193: (const uint8_t *)
isn't spd already of this type?
You're correct, I just changed the input param to add const in this patchset revision, so this cast is no longer required.
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c... File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c... PS36, Line 83: spd_data_ptr
variables of type `void *` are very awkward to have on hand... […]
If you feel this is an issue, a bug should be written up and this fixed in a separate CL. Resolving for now.