View Change

3 comments:

• File src/lib/spd_bin.c:

  • Patch Set #36, Line 10: struct

    ugh, i see const is propagating... could you fix this API […]

    Yes, it was propagating, but the right thing to do.

    I'm hesitant to change the blk->spd_array[] from it's current type to a constant (it's an array, so it's likely initialized at some point).

  • Patch Set #36, Line 193: (const uint8_t *)

    isn't spd already of this type?

    You're correct, I just changed the input param to add const in this patchset revision, so this cast is no longer required.

• File src/soc/intel/cannonlake/cnl_memcfg_init.c:

  • Patch Set #36, Line 83: spd_data_ptr

    variables of type `void *` are very awkward to have on hand... […]

    If you feel this is an issue, a bug should be written up and this fixed in a separate CL. Resolving for now.

To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.