Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47182 )
Change subject: soc/intel/tigerlake: Add PCH PCIe RPs wake up events to event log
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47182/2/src/soc/intel/tigerlake/elo...
File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/47182/2/src/soc/intel/tigerlake/elo...
PS2, Line 53: pci_dev_is_wake_source
It looks like `pci_dev_is_wake_source()` is defined in pci_device.c which is not included in smm- stage. I think we should move it to pci_ops.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icebcac3b69c605ecf6df37733b641397ea3c3ad0
Gerrit-Change-Number: 47182
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 20:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment