Hello Lance Zhao, build bot (Jenkins), Lijian Zhao, Furquan Shaikh, Paul Menzel, Angel Pons, Patrick Rudolph, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42608
to look at the new patch set (#13).
Change subject: mb/up/squared/gpio: 1/3 Decode raw register values ......................................................................
mb/up/squared/gpio: 1/3 Decode raw register values
Use the intelp2m utility [1,2] with -fld=cb options to convert the pad configuration format with the raw values of the DW0 and DW1 registers to the format with the bit fiends macros: PAD_FUNC(), PAD_RESET(), PAD_TRIG(), PAD_BUF(), PAD_PULL(), etc... Also use the -ii options to generate the target macro in the comments, so that it is easier to understand what result we should get:
./intelp2m -ii -fld cb -t 1 -p apl -file ./up-gpio.h
This is part of the patch set "mb/up/squared: Rewrite pad config using intelp2m":
CB:42608 - 1/3 Decode raw register values CB:42915 - 2/3 Exclude fields that are not in PAD_CFG* CB:39765 - 3/3 Converts bit field macros to PAD_CFG
[1] https://github.com/maxpoliak/pch-pads-parser [2] https://review.coreboot.org/c/coreboot/+/35643
Tested with BUILD_TIMELESS=1, UP Squared, remains identical.
Change-Id: I2523439af8842365c7de901bdfad85ad16d25dcf Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/up/squared/gpio.h 1 file changed, 1,145 insertions(+), 505 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/42608/13