build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: add TX tracking for DRAM DVFS ......................................................................
Patch Set 1:
(25 comments)
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 436: dramc_dbg("%s %d called!\n", __func__, __LINE__); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 436: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 436: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 442: SET32_BITFIELDS(&ch[chn].ao.rk[2].dqsosc, RK2_DQSOSC_FREQ_RATIO_TX_0, (freq_shu1*8/freq_shu0)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 443: SET32_BITFIELDS(&ch[chn].ao.rk[2].dqsosc, RK2_DQSOSC_FREQ_RATIO_TX_1, (freq_shu2*8/freq_shu0)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 444: SET32_BITFIELDS(&ch[chn].ao.rk[2].dqsosc, RK2_DQSOSC_FREQ_RATIO_TX_3, (freq_shu0*8/freq_shu1)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 445: SET32_BITFIELDS(&ch[chn].ao.rk[2].dqsosc, RK2_DQSOSC_FREQ_RATIO_TX_4, (freq_shu2*8/freq_shu1)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 446: SET32_BITFIELDS(&ch[chn].ao.rk[2].dummy_rd_bk, RK2_DUMMY_RD_BK_FREQ_RATIO_TX_6, (freq_shu0*8/freq_shu2)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 447: SET32_BITFIELDS(&ch[chn].ao.rk[2].dummy_rd_bk, RK2_DUMMY_RD_BK_FREQ_RATIO_TX_7, (freq_shu1*8/freq_shu2)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2171: dramc_dbg("%s %d called!\n", __func__, __LINE__); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2171: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2171: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2196: dramc_dbg("DQSOscCnt B0=0x%X, B1=0x%X\n", dqs_osc_cnt[0] , dqs_osc_cnt[1]); space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2240: dramc_dbg("%s %d called!\n", __func__, __LINE__); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2240: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2240: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2255: tck = 1000000 /clock_rate; need consistent spacing around '/' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2257: dqs_cnt = (mr18 & 0xFF) | ((mr19 & 0xFF) <<8); need consistent spacing around '<<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2259: dqs_osc = mr23*16 *1000000 / (2 * dqs_cnt * clock_rate); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2263: dqs_osc = 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2263: dqs_osc = 0; please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2263: dqs_osc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2288: dramc_dbg("%s %d called!\n", __func__, __LINE__); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2288: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37996/1/src/soc/mediatek/mt8183/dra... PS1, Line 2288: dramc_dbg("%s %d called!\n", __func__, __LINE__); please, no spaces at the start of a line