Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38780 )
Change subject: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
LGTM but would also like Furquan's (or Aaron's) second opinion.
https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... PS2, Line 65: if (get_recovery_mode_switch()) BTW, this is slightly unrelated but for further improvement of this function I would consider moving this to the end of the function (to allow compile-time elimination in all relevant stages). (Or just take this and the vboot_logic_executed() check out so we'll hit an assertion in vboot_get_context() if any code calls this before recovery reason can be known, which they really shouldn't anyway.)