LGTM but would also like Furquan's (or Aaron's) second opinion.
Patch set 2:Code-Review +1
1 comment:
File src/security/vboot/bootmode.c:
Patch Set #2, Line 65: if (get_recovery_mode_switch())
BTW, this is slightly unrelated but for further improvement of this function I would consider moving this to the end of the function (to allow compile-time elimination in all relevant stages). (Or just take this and the vboot_logic_executed() check out so we'll hit an assertion in vboot_get_context() if any code calls this before recovery reason can be known, which they really shouldn't anyway.)
To view, visit change 38780. To unsubscribe, or for help writing mail filters, visit settings.